Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn URLs into clickable <a> tags #35

Merged
merged 1 commit into from Dec 11, 2020
Merged

Turn URLs into clickable <a> tags #35

merged 1 commit into from Dec 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2020

Done

@ctrager ctrager merged commit 5687ae9 into ctrager:master Dec 11, 2020
@ctrager
Copy link
Owner

ctrager commented Dec 11, 2020

Is there something you want to work on? A feature? Changing how the code is written?

@ghost
Copy link
Author

ghost commented Dec 11, 2020

How about using this? https://docs.microsoft.com/en-us/aspnet/core/security/authorization/claims?view=aspnetcore-5.0
Interesting how it works with Razor pages.

@ctrager
Copy link
Owner

ctrager commented Dec 11, 2020

Wow, you and I are VERY different.

@ghost
Copy link
Author

ghost commented Dec 11, 2020

Wow, you and I are VERY different.

?

@ghost
Copy link
Author

ghost commented Dec 11, 2020

Are you talking about coding style?

@ctrager
Copy link
Owner

ctrager commented Dec 11, 2020

My "we are very different" is related to the authorization thing. Right now the app has to little bools, is_admin, is_report_only and simple one-line "if" logic to ask whether they are set to true or false and react. You are proposing we wrap those bools in the Service abstraction and use the Service abstraction to present at least two more abstractions, "Claims" and "Policy". The end result is instead of a simple procedural approach that any programmer since 1970 would be able to understand immediatly, you would replace it with a declarative approach that works kinda magically until somebody really digs into it.

Look, I'm not against all magical declaratives. I'm using [FromQuery] and [BindProperty]. But those for sure reduce the lines of code I write and increase the dependability of the app. Your Claims thing, for Budoco, ADDS to the lines of code and adds to the complexity and opacity.

@ctrager
Copy link
Owner

ctrager commented Dec 11, 2020

@ghost
Copy link
Author

ghost commented Dec 11, 2020

Ok. I can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants