Updates to make annotate smarter about when to touch a model #31
Conversation
… combination of the new schema are different than that of the old (i.e., don't regenerate if columns happen to be in a different order. That's just how life is sometimes) Grab old specification even if it has \r\n as line endings rather than pure \ns Remove gemspec line causing a warning
|
Thanks for your patch. I'll be going over the pull queue shortly; just wanted to let you know that someone is reading these :-) |
| @@ -10,7 +10,7 @@ Gem::Specification.new do |s| | |||
| s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version= | |||
| s.authors = ["Cuong Tran", "Alex Chaffee", "Marcos Piccinini"] | |||
| s.date = %q{2009-10-23} | |||
| s.default_executable = %q{annotate} | |||
| #s.default_executable = %q{annotate} | |||
There was a problem hiding this comment.
Is this necessary for this patch? If not, could you resubmit the patch without this change?
There was a problem hiding this comment.
default_executable is deprecated so the sooner the better
Sent from my iPhone
On Jun 21, 2011, at 2:18 PM, ctranreply@reply.github.com wrote:
@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
s.authors = ["Cuong Tran", "Alex Chaffee", "Marcos Piccinini"]
s.date = %q{2009-10-23}
- s.default_executable = %q{annotate}
- #s.default_executable = %q{annotate}
Is this necessary for this patch?
Reply to this email directly or view it on GitHub:
https://github.com/ctran/annotate_models/pull/31/files#r49415
There was a problem hiding this comment.
I'm so out of date :-)
Will merge the patch.
Updates to make annotate smarter about when to touch a model
Recognize column+type, and don't change a file unless the column+type combination of the new schema are different than that of the old (i.e., don't regenerate if columns happen to be in a different order. That's just how life is sometimes)
Grab old specification even if it has \r\n as line endings rather than pure \ns
Remove gemspec line causing a warning