New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to exclude STI subclasses from annotation #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a way to exclude a single file from the exclude_sti_subclasses option? An opt-in option, opposite the opt-out option of |
no, not as this is currently implemented |
This doesn't look like it breaks anything: venuenext#1 |
Can you squash the commits and fix the broken CI tests? Thanks |
ethnext
force-pushed
the
d_exclude_sti_subclasses
branch
from
May 10, 2016 14:49
0416341
to
ff76c18
Compare
ethnext
force-pushed
the
d_exclude_sti_subclasses
branch
from
May 10, 2016 14:54
ff76c18
to
694a44e
Compare
not sure about the semaphore failure now. it doesn't look related to changes I made. |
Thanks! |
johncarney
pushed a commit
to johncarney/annotate_models
that referenced
this pull request
Jun 19, 2017
* add option to exclude STI subclasses from annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option named
exclude_sti_subclasses
and code which checks if a model has a superclass under AR::B with the same table in order to exclude STI subclasses from annotation.this is a need I have on a project with a large number of subclasses of certain models, where annotating every one generates a lot of noise on any schema change, so I prefer to just annotate the parent class.