Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/annotate.rb #707

Merged
merged 13 commits into from
Dec 30, 2019
Merged

Refactor lib/annotate.rb #707

merged 13 commits into from
Dec 30, 2019

Commits on Dec 25, 2019

  1. Copy skip_on_migration?, include_routes?, and include_models? methods

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    72f3ac6 View commit details
    Browse the repository at this point in the history

  2. Make methods point to Helpers class methods

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    7a463d2 View commit details
    Browse the repository at this point in the history

  3. Rerun rubocop --auto-gen-config

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    d880737 View commit details
    Browse the repository at this point in the history

  4. Replace usages of methods to point to Helpers class instead

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    d7c290b View commit details
    Browse the repository at this point in the history

  5. Remove redundant methods from Annotate

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    bd5564b View commit details
    Browse the repository at this point in the history

  6. Copy .true? to Annotate::Helpers

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    048b7dc View commit details
    Browse the repository at this point in the history

  7. Redirect usages of .true? to refer to Helpers.true?

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    91708a8 View commit details
    Browse the repository at this point in the history

  8. Copy .fallback to Helpers

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    c6ea1ff View commit details
    Browse the repository at this point in the history

  9. Changes usages of .fallback to use Helpers.fallback instead

    @drwl
    drwl committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    73f9aa1 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2019

  1. Copy .reset_options into Helpers

    @drwl
    drwl committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    6c1271b View commit details
    Browse the repository at this point in the history

  2. Move options constants into Constants module

    @drwl
    drwl committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    d2b0a55 View commit details
    Browse the repository at this point in the history

  3. Add Constants to spec_helper

    @drwl
    drwl committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    ef39676 View commit details
    Browse the repository at this point in the history

  4. Remove .all_options from lib/annotate.rb 

    This change converts .all_options into a constant and moves it into Annotate::Constants. It also changes usages of .all_options.
    @drwl
    drwl committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    cdf40c3 View commit details
    Browse the repository at this point in the history