Add Dockerfile to project #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests require RVM to run. Without them they can't run. Added Dockerfile to make it easier to run the project in an isolated environment.
|
cc @ctran was working on updating integration tests but found out that they:
|
|
Just realized I prematurely merged this. Should have gotten #708 working and added the Dockerfile and any other scripts there. |
|
Is this for running things locally or on CI? |
|
Would be for running the integration tests locally, for people who don't have rvm installed. The motivation for this was wanting to upgrade the integration specs, only to realize they haven't been running AND I'm not able to run them with my current setup (using rbenv). |
drwl
added a commit
that referenced
this pull request
Jan 19, 2020
Dockerfile was added in #710 to make it easier to run integration tests locally.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
The integration tests require RVM to run. Without them they can't run. Added Dockerfile to make it easier to run the project in an isolated environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests require RVM to run. Without them they can't run.
Added Dockerfile to make it easier to run the project in an isolated environment.