Refactor RSpec for AnnotateModels (1) #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
approved these changes
Jan 19, 2020
| (@model_file_name, @file_content) = write_model 'user.rb', <<-EOS | ||
| class User < ActiveRecord::Base | ||
| end | ||
| (@model_file_name, @file_content) = write_model 'user.rb', <<~EOS |
There was a problem hiding this comment.
I looked up what the differences are in the doc string <<- vs <<~. Learning something new 👍
There was a problem hiding this comment.
cf. https://www.rubyguides.com/2018/11/ruby-heredoc/
I like <<~ because it makes code more clean.
When using VS Code, both strings indented with <<~ and that of <<- can be collapsed, but the latter looks bad.
There was a problem hiding this comment.
Yep the <<~ does look more clean. I think that it may have not existed when that spec was written but now it does 😊
| end | ||
| end | ||
|
|
||
| context 'without additional_file_patterns' do | ||
| context 'when additional_file_patterns is not specified is the options' do |
There was a problem hiding this comment.
Some typos here, but we can clean that up in a later commit :)
There was a problem hiding this comment.
Thanks, I fixed it in #731.
| end | ||
| end | ||
|
|
||
| context 'without additional_file_patterns' do | ||
| context 'when additional_file_patterns is not specified is the options' do |
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
I refactored and structuralized RSpec test cases of AnnotateModels for readability and scalability because it was too complex to read. cf. ctran#718 In this PR, I refactored test cases of some methods in `AnnotateModels`. I will refactor test cases of other methods in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored and structuralized RSpec test cases of AnnotateModels for readability and scalability because it was too complex to read.
cf. #718
In this PR, I refactored test cases of some methods in
AnnotateModels.I will refactor test cases of other methods in another PR.