Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AnnotateRoutes.rewrite_contents_with_header #730

Conversation

nard-tech
Copy link
Collaborator

@nard-tech nard-tech commented Jan 20, 2020

I removed AnnotateRoutes.rewrite_contents_with_header because the logic of AnnotateRoutes.rewrite_contents_with_header is as same as .rewrite_contents.

Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@drwl drwl merged commit db8b099 into ctran:develop Jan 20, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_routes/rewrite_contents_with_header_v2 branch January 20, 2020 18:35
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
I removed `AnnotateRoutes.rewrite_contents_with_header` because the logic of `AnnotateRoutes.rewrite_contents_with_header` is as same as `.rewrite_contents`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants