Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test cases for AnnotateRoutes.remove_annotations #748

Merged

Conversation

nard-tech
Copy link
Collaborator

Refactor of test cases for AnnotateRoutes.remove_annotations after #736.

Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one typo

root 'root#index'
end
EOS
context 'When custome comments are above route map' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo custome?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pointing out my mistake.
I fixed it.

@drwl drwl added the reviewed label Feb 4, 2020
Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@drwl drwl merged commit d4c04ff into ctran:develop Feb 6, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_routes/rspec_v2 branch February 6, 2020 06:11
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
Refactor of test cases for AnnotateRoutes.remove_annotations after ctran#736.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants