Refactor test cases of AnnotateRoutes as for Rake versions #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI for 2.4.x is failed due to recent update of seattlerb/sexp_processor. I made a PR of |
|
seattlerb/sexp_processor was fixed and CI have passed. Please review this PR. |
|
I fixed conflict of |
drwl
approved these changes
Feb 13, 2020
| expect(File).to receive(:open).with(ROUTE_FILE, 'wb').and_yield(mock_file) | ||
| expect(File).to receive(:read).with(ROUTE_FILE).and_return(route_file_content) | ||
|
|
||
| expect(AnnotateRoutes).to receive(:`).with('rake routes').and_return(rake_routes_result) |
There was a problem hiding this comment.
This is interesting 🤔. I had no idea that when you do
`rake routes`
It sends the message with method name `. Very neat.
| expect(mock_file).to receive(:puts).with(expected_result) | ||
| expect(AnnotateRoutes).to receive(:puts).with(MESSAGE_ANNOTATED) |
There was a problem hiding this comment.
Same with puts, I didn't know that the object receiving the message is whatever object that it's being called in.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Refactor test cases for entire rewrite in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test cases for entire rewrite in the future.