[Revert #677] Fix column default annotations #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
force-pushed
the
drwl/revert-677
branch
from
1210064
to
765bd90
Compare
|
I've confirmed this fixes the issue described in #762 in our application. Thanks! |
|
@drwl any sense of when this will be released? |
|
@erikkessler1 I tried releasing it yesterday but there's an issue with our gem publish release workflow. Hopefully tonight, but looking to do it this week at the latest. |
|
Sounds good @drwl. Thank you for the update! |
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in #762 that column defaults were broken. This reverts changes made in #677 to restore the expected behavior of column defaults.
For the time being columns with associated enums won't be working.