Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xcframework target naming issues with Swift versions before 5.8 #29

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

ctreffs
Copy link
Owner

@ctreffs ctreffs commented Jun 29, 2023

Description

  • Fixes an issue for Swift tool versions before 5.8 that does not allow a different target name than the xcframework referenced in a binary target.
  • extends GH actions to test with minimum and maximum supported Swift version.

Checklist

  • I've read the Contribution Guidelines
  • I've followed the coding style of the rest of the project.
  • I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.

@ctreffs ctreffs changed the title Extend GH actions Fix xcframework target naming issues with Swift versions before 5.8 Jun 29, 2023
@ctreffs ctreffs self-assigned this Jun 29, 2023
@ctreffs ctreffs added the bug Something isn't working label Jun 29, 2023
@ctreffs ctreffs marked this pull request as ready for review June 29, 2023 07:10
@ctreffs
Copy link
Owner Author

ctreffs commented Jun 29, 2023

Closes #28

@ctreffs ctreffs enabled auto-merge (squash) June 29, 2023 07:13
@ctreffs ctreffs merged commit 3b5bc24 into master Jun 29, 2023
6 checks passed
@ctreffs ctreffs deleted the gh-action-swift-5.6 branch June 29, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant