Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt current config item that is being deleted #1898

Merged
merged 3 commits into from
Jan 23, 2019
Merged

prompt current config item that is being deleted #1898

merged 3 commits into from
Jan 23, 2019

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Jan 21, 2019

TODO Item

image

This patch adds prompt message when deleting config item, the prompt message may need ajustment if required.

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #1898 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1898      +/-   ##
============================================
+ Coverage     50.21%   50.26%   +0.04%     
- Complexity     1926     1928       +2     
============================================
  Files           394      394              
  Lines         12051    12051              
  Branches       1224     1224              
============================================
+ Hits           6052     6057       +5     
+ Misses         5545     5540       -5     
  Partials        454      454
Impacted Files Coverage Δ Complexity Δ
...work/apollo/biz/message/DatabaseMessageSender.java 67.34% <0%> (+10.2%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3aa3c...1e467a7. Read the comment docs.

@lepdou lepdou merged commit 96441c0 into apolloconfig:master Jan 23, 2019
@kezhenxu94 kezhenxu94 deleted the enhancement/delete-config-item branch January 23, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants