Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting apollo.cacheDir from app.properties #2317

Merged
merged 1 commit into from
Jun 7, 2019
Merged

support setting apollo.cacheDir from app.properties #2317

merged 1 commit into from
Jun 7, 2019

Conversation

erystasius
Copy link
Contributor

Fixes #2306

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #2317 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2317      +/-   ##
============================================
- Coverage     49.99%   49.94%   -0.05%     
  Complexity     1981     1981              
============================================
  Files           402      402              
  Lines         12400    12402       +2     
  Branches       1273     1274       +1     
============================================
- Hits           6199     6194       -5     
- Misses         5758     5765       +7     
  Partials        443      443
Impacted Files Coverage Δ Complexity Δ
...va/com/ctrip/framework/apollo/util/ConfigUtil.java 94.57% <100%> (+0.08%) 49 <0> (+1) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 80.24% <0%> (+0.61%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c370e...7b9f0f4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 53.516% when pulling 7b9f0f4 on erystasius:cache-dir-from-app-properties into 89c370e on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 8d82dc1 into apolloconfig:master Jun 7, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 10, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/META-INF/app.properties 中设置 cacheDir 的问题
4 participants