Add support for fractional width and height values #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should work now, can be merged if you like it :) |
Mitsunee
commented
Mar 17, 2021
| const { clientWidth, clientHeight } = $image; | ||
| const { width, height } = $image.getClientRects()[0]; | ||
| const clientWidth = Math.ceil(width); | ||
| const clientHeight = Math.ceil(height); |
There was a problem hiding this comment.
clientWidth and clientHeight stay, but are now a ceiled version of the "real" dimensions of the image.
Mitsunee
commented
Mar 17, 2021
| @@ -124,8 +124,12 @@ class Freezeframe { | |||
| private _process(freeze: Freeze): Promise<Freeze> { | |||
| return new Promise((resolve) => { | |||
| const { $canvas, $image, $container } = freeze; | |||
| const { clientWidth, clientHeight } = $image; | |||
| const { width, height } = $image.getClientRects()[0]; | |||
There was a problem hiding this comment.
new way to read the computed dimensions of the image that supports floating point numbers.
Mitsunee
commented
Mar 17, 2021
|
|
||
| $canvas.style.width = `${width}px`; | ||
| $canvas.style.height = `${height}px`; |
There was a problem hiding this comment.
use inline-styles as an override to make sure the dimensions match the image
Mitsunee
commented
Mar 17, 2021
|
|
||
| $canvas.style.width = `${width}px`; | ||
| $canvas.style.height = `${height}px`; | ||
| $canvas.setAttribute('width', clientWidth.toString()); | ||
| $canvas.setAttribute('height', clientHeight.toString()); |
There was a problem hiding this comment.
canvas keeps using clientWidth and clientHeight as it requires its dimensions to be integers (or it doesn't draw the imag at all)
|
thank you @Mitsunee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found the demo page on an article and noticed the image jumps a bit when pausing, so I decided to look into it and found that the way the width and height are read is what a property that only supports integers. With responsive widths it's common to have floating point numbers, so
getClientRects()has a much cleaner result. Hope this helps, I'll definitely be trying this library if I ever have a gif somewhere (:Edit: just noticed this doesn't yet fully fix it on the 2nd example on the demo page, maybe inline-styles should be used to set the dimensions of the canvas?implemented and hopefully works now, also added explanations in the commit