(issue)Redesigned store #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: this is incomplete This is for issue #71. - Updated the store - Removed ads.js - Reordered battlegrounds in live.js
Previously the store would only work for landscape, but now it works on both.
- Removed all `main>` from `main>section` - Added empty lines for prettiness - Added blank upgrades button container - Added a comment for scripts
ghost
self-assigned this
|
When you turn it to landscape it gets crushed |
|
@VishwamR, can you send me a screenshot? |
|
Wait never mind. I understand what you mean. That is because you are viewing in a browser on a mobile device. This doesn't happen on a computer and users on mobile device will most likely have the app because that is either how they found out or they actually want to play so they download it to remove the browser bars. This should be fine. |
- Removed wood background - Removed merchant - Removed shuffle icon
VishwamR
previously approved these changes
Dec 12, 2017
This resolves issue #157. - Added title attributes to applicable elements on the store page - Cleaned up css - Cleaned up js - Added character upgrades - Added GA events - Added comments to uncommented code
ghost
self-requested a review
ghost
removed their request for review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new store.
Changes:
Please check it out to see if there should be any improvements or changes before publishing, @ethanchoo, @VishwamR, @datdopegamer
I still have to add before merging: