Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_JpnPostalMark is missing cmap entry for U+3012 #2

Open
dscorbett opened this issue Feb 21, 2021 · 5 comments · May be fixed by #15
Open

_JpnPostalMark is missing cmap entry for U+3012 #2

dscorbett opened this issue Feb 21, 2021 · 5 comments · May be fixed by #15
Labels
bug Something isn't working

Comments

@dscorbett
Copy link

Version 1.1 includes a glyph called _JpnPostalMark whose name implies it represents U+3012 POSTAL MARK. However, it is mapped to the nearly homoglyphic but otherwise unrelated U+20B8 TENGE SIGN. Was that intentional?

@ctrlcctrlv
Copy link
Owner

It was intentional, however, it seems that I forgot the cmap entry that would make _JpnPostalMark resolve to both U+20B8 and U+3012…

@ctrlcctrlv ctrlcctrlv changed the title Possibly wrong code point for _JpnPostalMark _JpnPostalMark is missing cmap entry for U+3012 Feb 21, 2021
@ctrlcctrlv ctrlcctrlv added the bug Something isn't working label Feb 21, 2021
@dscorbett
Copy link
Author

I just downloaded version 1.2, but it doesn’t support U+3012.

@ctrlcctrlv
Copy link
Owner

Really? I believe you, but you can see that I added it:

Maybe a fontmake issue, or perhaps MFEKstroke doesn't understand multiple <unicode> values (MFEK/glyphparser.rlib issue).

Please double check.

@dscorbett
Copy link
Author

$ wget https://github.com/ctrlcctrlv/FRBAmericanCursive/releases/download/v1.2/FRBAmericanCursive.zip
$ unzip FRBAmericanCursive.zip
$ hb-shape dist/FRBAmericanCursive-400-Regular.otf -u 3012
[.notdef=0+500]

@ctrlcctrlv
Copy link
Owner

Thank you, reopened. I think the problem is in MFEK/glifparser.rlib. I'm not sure when that'll be fixed, but I'll make sure to triple-check this before 1.3. Thanks for your diligence.

@ctrlcctrlv ctrlcctrlv reopened this Apr 3, 2021
@ctrlcctrlv ctrlcctrlv linked a pull request Dec 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants