Skip to content
This repository has been archived by the owner on Jun 13, 2020. It is now read-only.

Remove 1d1 (Illogical die configuration). #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

infoburp
Copy link

1d2 is a coin, but 1d1 is a pointless die, as it always has the same result (1).

@infoburp
Copy link
Author

There are other problems, for example "dice 0.1d0.1" is considered valid. I'll take a better look at this over the next few hours..

@infoburp
Copy link
Author

infoburp commented Nov 1, 2014

Thanks for the feedback in your stream, Fredrick. As is this patch works (prevents 1d1), but it still accepts silly inputs like 1d1.1. I'm just setting up a local testing server so I can submit good code, and I'm happy to open another PR if/when you accept/close this one.

@infoburp
Copy link
Author

infoburp commented Nov 1, 2014

As I said in the stream, my next PR will hopefully modify more than 1 char...

Update to latest 8ch code
@anonfagola
Copy link
Contributor

The code says it "intifies" the numbers, so decimals shouldn't be a problem.

@infoburp
Copy link
Author

Ok, but a one sided die still makes no logical sense, as it always returns 1...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants