-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animate and easing bugs? #34
Comments
Thank you for any help! =) |
Did you use the demo page as example? I've just tested it and it works as expected! |
Ah, the readme file made it seem like jqueryui was optional. It is working now using jquery 3.1.0 and jqueryui 1.12.1. FYI it is not working with jquery latest (nor does it claim to be) Although, now the sidebar does not want to stay open on the page. As you can see here (https://imgur.com/a/VqOtD) it pops out before being immediate sent back off the page. Maybe it's because the physics in my chart are still active? I tried setting:
|
jQuery-UI is indeed optional. However you used an example that used it. |
I closed this issue since it's not a bug. |
The issue was that my js was loading twice so it was opening and then immediately closing the open. It was due to the way I was extending my js in my templates. |
github
npm
-npm install simpler-sidebar
bower
-bower install simpler-sidebar
dist/jquery.simpler-sidebar.js
file is the same as the latest versionbower install simpler-sidebar -F
to force latest version on conflictdoc
folderdoc
foldereditorconfig
plugin in my editorjscs
plugin in my editorjshint
plugin in my editorgrunt lint
to test if I made some mistakesgrunt build
to apply changesdemo
folder on my computerActual behavior
When I click on the object that I expect to trigger the sidebar to open, I get the following error in the js console:
// if i try jquery 3.1.0
//
jquery.simpler-sidebar.js:213 Uncaught TypeError: $sidebar.animate is not a function
at animateOpen (VM2272 jquery.simpler-sidebar.js:213)
at HTMLAnchorElement. (VM2272 jquery.simpler-sidebar.js:288)
at HTMLAnchorElement.dispatch (VM2265 jquery-3.2.1.slim.min.js:3)
at HTMLAnchorElement.q.handle (VM2265 jquery-3.2.1.slim.min.js:3)
animateOpen @ jquery.simpler-sidebar.js:213
(anonymous) @ jquery.simpler-sidebar.js:288
dispatch @ jquery-3.2.1.slim.min.js:3
q.handle @ jquery-3.2.1.slim.min.js:3
// if i try jquery 3.2.1 and 2.2.4
//
jquery.min.js:3 Uncaught TypeError: r.easing[this.easing] is not a function
at init.run (VM2587 jquery.min.js:3)
at i (VM2587 jquery.min.js:3)
at Function.r.fx.timer (VM2587 jquery.min.js:3)
at gb (VM2587 jquery.min.js:3)
at HTMLDivElement.g (VM2587 jquery.min.js:3)
at Function.dequeue (VM2587 jquery.min.js:3)
at HTMLDivElement. (VM2587 jquery.min.js:3)
at Function.each (VM2587 jquery.min.js:2)
at r.fn.init.each (VM2587 jquery.min.js:2)
at r.fn.init.queue (VM2587 jquery.min.js:3)
Steps to reproduce the behavior
<a href="#" id="sidebar-main-trigger" class=".toggle-sidebar">test</a>
Expected behavior
I expect to click the # link above and have the sidebar appear
The text was updated successfully, but these errors were encountered: