-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMD support: dependency globals #19
Comments
Hey @wmik 馃憢 Thanks for opening this! You are correct... https://unpkg.com/redux@4.0.1/dist/redux.js 馃槉 Would you be open to creating a PR to fix? Glad you are liking the package. 馃憤 Have you been trying to use it much within a UMD context? Are you loading directly in the browser? I was wondering if I should consider bundling all the dependencies, except for React and React DOM, into the UMD build to avoid more difficult initial setups. I pretty much always work from a Node based environment with a bundler so I am not the best to decide this. Would appreciate your thoughts. 馃憤 |
Sure I'd be happy to take this. Yes I'm attempting to load it directly using a script tag which also requires the dependencies to be setup manually. Side note:
|
I could be wrong but I think redux and redux-thunk export their globals as
Redux
andReduxThunk
respectively.Great package btw 馃檪 馃帀 馃挌
The text was updated successfully, but these errors were encountered: