Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD support: dependency globals #19

Closed
wmik opened this issue Nov 8, 2018 · 2 comments
Closed

UMD support: dependency globals #19

wmik opened this issue Nov 8, 2018 · 2 comments

Comments

@wmik
Copy link
Contributor

wmik commented Nov 8, 2018

I could be wrong but I think redux and redux-thunk export their globals as Redux and ReduxThunk respectively.

Great package btw 馃檪 馃帀 馃挌

@wmik wmik changed the title UMD support: Redux global UMD support: dependency globals Nov 8, 2018
@ctrlplusb
Copy link
Owner

ctrlplusb commented Nov 8, 2018

Hey @wmik 馃憢

Thanks for opening this!

You are correct...

https://unpkg.com/redux@4.0.1/dist/redux.js
https://unpkg.com/redux-thunk@2.3.0/dist/redux-thunk.js

馃槉

Would you be open to creating a PR to fix?

Glad you are liking the package. 馃憤

Have you been trying to use it much within a UMD context? Are you loading directly in the browser? I was wondering if I should consider bundling all the dependencies, except for React and React DOM, into the UMD build to avoid more difficult initial setups. I pretty much always work from a Node based environment with a bundler so I am not the best to decide this. Would appreciate your thoughts. 馃憤

@wmik
Copy link
Contributor Author

wmik commented Nov 8, 2018

Sure I'd be happy to take this.

Yes I'm attempting to load it directly using a script tag which also requires the dependencies to be setup manually.
I'll try testing amd as well while applying the patch.

Side note:

  • Not sure how you feel about bundling prop-types for production. I noticed it's only used here
  • Also doubt shallowequal has a umd distribution but it should be easy to create one since it's relatively small.

@wmik wmik mentioned this issue Nov 8, 2018
ctrlplusb pushed a commit that referenced this issue Nov 8, 2018
ctrlplusb pushed a commit that referenced this issue Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants