fixes computed error when get() returns undefined #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 20 20
Lines 571 572 +1
Branches 104 105 +1
=======================================
+ Hits 558 559 +1
Misses 11 11
Partials 2 2
Continue to review full report at Codecov.
|
|
Hey @jchamb; Thanks for this. This seems likely a reasonable temporary fix. I'll make a note to do some more digging into why the Appreciate your help! 👍 |
ctrlplusb
previously approved these changes
Mar 21, 2020
ctrlplusb
reviewed
Mar 21, 2020
src/create-reducer.js
Outdated
| @@ -47,7 +47,8 @@ export default function createReducer( | |||
| : stateAfterActions; | |||
| if (state !== next) { | |||
| computedProperties.forEach(({ parentPath, bindComputedProperty }) => { | |||
| bindComputedProperty(get(parentPath, next)); | |||
| const prop = get(parentPath, next); | |||
| if (prop) bindComputedProperty(prop); | |||
There was a problem hiding this comment.
Actually I have approved this PR already, but we should avoid implicit boolean conversion. I would change this to:
if (prop != null) bindComputedProperty(prop);
|
@ctrlplusb once I get some extra free time i'll create some repos I can share that mimic my split setup. I tried reproducing directly within a single repo and never could, so think this might be an issue with having my main store coming in as part of a dependancy. |
ctrlplusb
pushed a commit
that referenced
this pull request
Oct 14, 2020
* fixes computed error when get() returns undefined * avoids implicit boolean conversion
ctrlplusb
added a commit
that referenced
this pull request
Oct 14, 2020
* Adds Generics API and TypeScript improvements (#457) * Fix statemapper eating up classes * Remove scratch file * Adds support for generic values * Adds support for generic values * Adds useLocalStore hook, deprecates createComponentStore (#458) * Adds useLocalStore hook * Adds typings for useLocalStore and it returns store now too * Adds docs for useLocalStore * Updates website * Bumps version * Fixes rollup config * Bumps version * Fixes website -> docs -> quick-start.md (#453) * Fixes computed properties error for dynamically added model (#455) * fixes computed error when get() returns undefined * avoids implicit boolean conversion * Bumps version * Updates website * Disables eslint against TypeScript files * Upgrades dependencies * Modified the useLocalStore API to include prev state/config and change config into a factory function * Bumps version * Upgrade website dependencies * Upgrades dependencies * Replaces immer-peasy with patched immer * Bumps version * Fixes bug with evolved models when rehydrating from merge or mergeDeep strategy * Bumps version * Adds patches to npm bundle * Bumps version * Adds a script to be able to run patch of immer correctly * Bumps version * Improves error handling of immer patch script * Bumps version * Fixes TypeScript state mapper * Bump version * Removes depth limit on TypeScript state mapper * Bumps version * Upgrades dependencies * Removes prop-types as a dependency * Adds deprecation message to createComponentStore * Bumps version * Small refactor to persistence implementation * The store.persist.flush API now returns a Promise * Improves persist flush API and adds types and docs on the store instance persist APIs. * Bumps version * Moves to microbundle as our bundler * Adds mangled properties for internals * Bump * Fixes persist data rehydration on dynamically added models and introduces an API by which to await the rehydration. * Bumps version * Moves tests to root of project * Upgrades dependencies * Fix invalid properties being exposed via getActions in TypeScript * Fixes listeners TypeScript mappings and removes restrictions. * Updates dependencies * Fix state mapper and add giant model stress test * Upgrades to prettier 2 * Bumps version * Fixes package lock and runs prettier 2 again * Fixes and improvements to the TypeScript typings * Bumps version * Updates redux-thunk middleware position to allow user overriding via the store middleware config * Bumps version * Fixes typings issue for computed properties and updates docs with known issue on them * Bumps version * added correct homepage url (#470) * refactor(recipesDoc): renamed selector to computed (#466) I believe the name changed a while ago, but wasn't reflected in this doc. * Adds known issue about computed property destructuring * shortened links (#469) * Improves the persist API docs * Adds community extensions page * Adds test to ensure immer Set and Map support works as expected * Adds unstable_effectOn API * Upgrades depenendencies * Upgrades to TypeScript 3.9 * Updates website * Bumps version * Upgrade dev deps * Upgrades to immer@7 with supreme joy * Upgrades TS deps * Bumps version * Fixes broken test for debug helper * Updates website * Refactors store helpers to be immutable * Upgrade dev deps * Upgrades deps * Bumps version * Disable persist for server side rendering * Upgrades dev dependencies * Upgrades dependencies * Ensures that storage engines are lazily accessed * Big rewrite to the persistences documentation * Minor fixes to typescript definitions * Bumps version * don't persist computed fields (#540) * Simplifies thunks and effects. No more error handling. Introduces an explicity 'fail' API for thunks. * Component stores drop support for initialData runtime prop and adds support for runtime modification to injections. * DevTools are now only enabled by default if not in production * Bumps version * A minor update to consuming-state.md (#490) * Update README.md * Update README.md * A minor update to consuming-state.md Co-authored-by: Sean Matheson <sean@ctrlplusb.com> * Updates docs per @gamtiq PR#507 * Updates docs per @gamtiq PR#508 * Updates docs per @gamtiq PR#509 * Updates docs per @gamtiq PR#517 * Updates docs per @minnacaptain PR#519 * Fix persist transformers order @czeslaaw #514 * Reintroduces initialData as runtimeModel on createContextStore * Updates website and improves persist API * Bumps version * Updates readme * Updates readme * Updates readme * Updates readme * Updates readme * Adds new scheduling and optimizations to persisting * Updates docs * Bump version * Computed properties now act againt their original immutable state * Updates docs and tests * Bumps version * Adds versioning to persist API, and new tutorials to website * Bumps version * Removes node 8 from travis build * Updated listeners to not respond to thunk fail type by default * Updates docs * Removes esm build * v4 * Removes temp file Co-authored-by: Hua Lu <lemonadedrink@gmail.com> Co-authored-by: Jake Chamberlain <jake@jchamb.com> Co-authored-by: Mohamed Nainar <mdnainar9615@gmail.com> Co-authored-by: Matthias Rougier <51899780+Matt-Swingvy@users.noreply.github.com> Co-authored-by: mighdoll <lee@underneath.ca> Co-authored-by: Ahmed Mohammed <amElnagdy@users.noreply.github.com>
jmyrland
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Adds Generics API and TypeScript improvements (#457) * Fix statemapper eating up classes * Remove scratch file * Adds support for generic values * Adds support for generic values * Adds useLocalStore hook, deprecates createComponentStore (#458) * Adds useLocalStore hook * Adds typings for useLocalStore and it returns store now too * Adds docs for useLocalStore * Updates website * Bumps version * Fixes rollup config * Bumps version * Fixes website -> docs -> quick-start.md (#453) * Fixes computed properties error for dynamically added model (#455) * fixes computed error when get() returns undefined * avoids implicit boolean conversion * Bumps version * Updates website * Disables eslint against TypeScript files * Upgrades dependencies * Modified the useLocalStore API to include prev state/config and change config into a factory function * Bumps version * Upgrade website dependencies * Upgrades dependencies * Replaces immer-peasy with patched immer * Bumps version * Fixes bug with evolved models when rehydrating from merge or mergeDeep strategy * Bumps version * Adds patches to npm bundle * Bumps version * Adds a script to be able to run patch of immer correctly * Bumps version * Improves error handling of immer patch script * Bumps version * Fixes TypeScript state mapper * Bump version * Removes depth limit on TypeScript state mapper * Bumps version * Upgrades dependencies * Removes prop-types as a dependency * Adds deprecation message to createComponentStore * Bumps version * Small refactor to persistence implementation * The store.persist.flush API now returns a Promise * Improves persist flush API and adds types and docs on the store instance persist APIs. * Bumps version * Moves to microbundle as our bundler * Adds mangled properties for internals * Bump * Fixes persist data rehydration on dynamically added models and introduces an API by which to await the rehydration. * Bumps version * Moves tests to root of project * Upgrades dependencies * Fix invalid properties being exposed via getActions in TypeScript * Fixes listeners TypeScript mappings and removes restrictions. * Updates dependencies * Fix state mapper and add giant model stress test * Upgrades to prettier 2 * Bumps version * Fixes package lock and runs prettier 2 again * Fixes and improvements to the TypeScript typings * Bumps version * Updates redux-thunk middleware position to allow user overriding via the store middleware config * Bumps version * Fixes typings issue for computed properties and updates docs with known issue on them * Bumps version * added correct homepage url (#470) * refactor(recipesDoc): renamed selector to computed (#466) I believe the name changed a while ago, but wasn't reflected in this doc. * Adds known issue about computed property destructuring * shortened links (#469) * Improves the persist API docs * Adds community extensions page * Adds test to ensure immer Set and Map support works as expected * Adds unstable_effectOn API * Upgrades depenendencies * Upgrades to TypeScript 3.9 * Updates website * Bumps version * Upgrade dev deps * Upgrades to immer@7 with supreme joy * Upgrades TS deps * Bumps version * Fixes broken test for debug helper * Updates website * Refactors store helpers to be immutable * Upgrade dev deps * Upgrades deps * Bumps version * Disable persist for server side rendering * Upgrades dev dependencies * Upgrades dependencies * Ensures that storage engines are lazily accessed * Big rewrite to the persistences documentation * Minor fixes to typescript definitions * Bumps version * don't persist computed fields (#540) * Simplifies thunks and effects. No more error handling. Introduces an explicity 'fail' API for thunks. * Component stores drop support for initialData runtime prop and adds support for runtime modification to injections. * DevTools are now only enabled by default if not in production * Bumps version * A minor update to consuming-state.md (#490) * Update README.md * Update README.md * A minor update to consuming-state.md Co-authored-by: Sean Matheson <sean@ctrlplusb.com> * Updates docs per @gamtiq PR#507 * Updates docs per @gamtiq PR#508 * Updates docs per @gamtiq PR#509 * Updates docs per @gamtiq PR#517 * Updates docs per @minnacaptain PR#519 * Fix persist transformers order @czeslaaw #514 * Reintroduces initialData as runtimeModel on createContextStore * Updates website and improves persist API * Bumps version * Updates readme * Updates readme * Updates readme * Updates readme * Updates readme * Adds new scheduling and optimizations to persisting * Updates docs * Bump version * Computed properties now act againt their original immutable state * Updates docs and tests * Bumps version * Adds versioning to persist API, and new tutorials to website * Bumps version * Removes node 8 from travis build * Updated listeners to not respond to thunk fail type by default * Updates docs * Removes esm build * v4 * Removes temp file Co-authored-by: Hua Lu <lemonadedrink@gmail.com> Co-authored-by: Jake Chamberlain <jake@jchamb.com> Co-authored-by: Mohamed Nainar <mdnainar9615@gmail.com> Co-authored-by: Matthias Rougier <51899780+Matt-Swingvy@users.noreply.github.com> Co-authored-by: mighdoll <lee@underneath.ca> Co-authored-by: Ahmed Mohammed <amElnagdy@users.noreply.github.com>
jmyrland
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Adds Generics API and TypeScript improvements (#457) * Fix statemapper eating up classes * Remove scratch file * Adds support for generic values * Adds support for generic values * Adds useLocalStore hook, deprecates createComponentStore (#458) * Adds useLocalStore hook * Adds typings for useLocalStore and it returns store now too * Adds docs for useLocalStore * Updates website * Bumps version * Fixes rollup config * Bumps version * Fixes website -> docs -> quick-start.md (#453) * Fixes computed properties error for dynamically added model (#455) * fixes computed error when get() returns undefined * avoids implicit boolean conversion * Bumps version * Updates website * Disables eslint against TypeScript files * Upgrades dependencies * Modified the useLocalStore API to include prev state/config and change config into a factory function * Bumps version * Upgrade website dependencies * Upgrades dependencies * Replaces immer-peasy with patched immer * Bumps version * Fixes bug with evolved models when rehydrating from merge or mergeDeep strategy * Bumps version * Adds patches to npm bundle * Bumps version * Adds a script to be able to run patch of immer correctly * Bumps version * Improves error handling of immer patch script * Bumps version * Fixes TypeScript state mapper * Bump version * Removes depth limit on TypeScript state mapper * Bumps version * Upgrades dependencies * Removes prop-types as a dependency * Adds deprecation message to createComponentStore * Bumps version * Small refactor to persistence implementation * The store.persist.flush API now returns a Promise * Improves persist flush API and adds types and docs on the store instance persist APIs. * Bumps version * Moves to microbundle as our bundler * Adds mangled properties for internals * Bump * Fixes persist data rehydration on dynamically added models and introduces an API by which to await the rehydration. * Bumps version * Moves tests to root of project * Upgrades dependencies * Fix invalid properties being exposed via getActions in TypeScript * Fixes listeners TypeScript mappings and removes restrictions. * Updates dependencies * Fix state mapper and add giant model stress test * Upgrades to prettier 2 * Bumps version * Fixes package lock and runs prettier 2 again * Fixes and improvements to the TypeScript typings * Bumps version * Updates redux-thunk middleware position to allow user overriding via the store middleware config * Bumps version * Fixes typings issue for computed properties and updates docs with known issue on them * Bumps version * added correct homepage url (#470) * refactor(recipesDoc): renamed selector to computed (#466) I believe the name changed a while ago, but wasn't reflected in this doc. * Adds known issue about computed property destructuring * shortened links (#469) * Improves the persist API docs * Adds community extensions page * Adds test to ensure immer Set and Map support works as expected * Adds unstable_effectOn API * Upgrades depenendencies * Upgrades to TypeScript 3.9 * Updates website * Bumps version * Upgrade dev deps * Upgrades to immer@7 with supreme joy * Upgrades TS deps * Bumps version * Fixes broken test for debug helper * Updates website * Refactors store helpers to be immutable * Upgrade dev deps * Upgrades deps * Bumps version * Disable persist for server side rendering * Upgrades dev dependencies * Upgrades dependencies * Ensures that storage engines are lazily accessed * Big rewrite to the persistences documentation * Minor fixes to typescript definitions * Bumps version * don't persist computed fields (#540) * Simplifies thunks and effects. No more error handling. Introduces an explicity 'fail' API for thunks. * Component stores drop support for initialData runtime prop and adds support for runtime modification to injections. * DevTools are now only enabled by default if not in production * Bumps version * A minor update to consuming-state.md (#490) * Update README.md * Update README.md * A minor update to consuming-state.md Co-authored-by: Sean Matheson <sean@ctrlplusb.com> * Updates docs per @gamtiq PR#507 * Updates docs per @gamtiq PR#508 * Updates docs per @gamtiq PR#509 * Updates docs per @gamtiq PR#517 * Updates docs per @minnacaptain PR#519 * Fix persist transformers order @czeslaaw #514 * Reintroduces initialData as runtimeModel on createContextStore * Updates website and improves persist API * Bumps version * Updates readme * Updates readme * Updates readme * Updates readme * Updates readme * Adds new scheduling and optimizations to persisting * Updates docs * Bump version * Computed properties now act againt their original immutable state * Updates docs and tests * Bumps version * Adds versioning to persist API, and new tutorials to website * Bumps version * Removes node 8 from travis build * Updated listeners to not respond to thunk fail type by default * Updates docs * Removes esm build * v4 * Removes temp file Co-authored-by: Hua Lu <lemonadedrink@gmail.com> Co-authored-by: Jake Chamberlain <jake@jchamb.com> Co-authored-by: Mohamed Nainar <mdnainar9615@gmail.com> Co-authored-by: Matthias Rougier <51899780+Matt-Swingvy@users.noreply.github.com> Co-authored-by: mighdoll <lee@underneath.ca> Co-authored-by: Ahmed Mohammed <amElnagdy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
@ctrlplusb I was never able to truly track down why the next prop in get() would be missing the newly added model definition, but the reduce would return an undefined which would throw the error. Simply validating existence after the get() made the error go away and still performed the correct binding of the computed.
In the repo that has this issue, I am using a store provided through a package dependency and it does a number of addModel calls directly after one another, but I was never able to fully reproduce the issue consistently.