Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize computed props #764

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Optimize computed props #764

merged 3 commits into from
Sep 15, 2022

Commits on Sep 15, 2022

  1. Optimize computed props 

    An attempt to optimize computed props, by improving
comparison of inputs & by checking if the value needs an update.

The value comparison uses a naive comparison of of the JSON stringified values.

This will support more complex inputs & avoid unneccessary updates for complex results (arrays, objects).

related to ctrlplusb#732
    @jmyrland @ctrlplusb
    jmyrland authored and ctrlplusb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    9d7f95d View commit details
    Browse the repository at this point in the history

  2. refactor: Modifies computed properties to use fast-deep-equals

    @ctrlplusb
    ctrlplusb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    9f38cc1 View commit details
    Browse the repository at this point in the history

  3. fix: Computed properties optimisations

    @ctrlplusb
    ctrlplusb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    53d4b4a View commit details
    Browse the repository at this point in the history