Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/action config (ability to pass a config object and disable immer) #628 #781

Merged
merged 10 commits into from
Nov 13, 2022
Merged

Feat/action config (ability to pass a config object and disable immer) #628 #781

merged 10 commits into from
Nov 13, 2022

Conversation

s900mhz
Copy link
Contributor

@s900mhz s900mhz commented Oct 2, 2022

Hey all,

This PR is to address this issue and milestone right here #628

Test were added, it's late here.. I didn't write tests for custom reducers. I can update this PR later with that.

@vercel
Copy link

vercel bot commented Oct 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
easy-peasy ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 11:50PM (UTC)

@jmyrland
Copy link
Collaborator

jmyrland commented Oct 2, 2022

Hi @s900mhz ! Thanks for looking into this.

With regards to the internal changes, @ctrlplusb has to do a review for this.

In the mean time, the API-docs & TS-types also needs to reflect these changes.

@s900mhz
Copy link
Contributor Author

s900mhz commented Oct 2, 2022

Sure thing! I'll work on the types and docs tonight.
I am open to any kind of discussion on the API. Just wanted to get this conversation started, we could really use this feature!

ctrlplusb
ctrlplusb reviewed Oct 25, 2022
View reviewed changes
index.d.ts Outdated
Comment on lines 624 to 625
* @param immer - If true, the action will be wrapped in an immer produce call. Otherwise, the action will update the state directly.
**/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Can we add that the default value is true.

@ctrlplusb
Copy link
Owner

Excellent stuff. Thanks for doing this. Just a few minors and we can get this merged. 🎉

s900mhz and others added 2 commits October 30, 2022 19:33
@s900mhz @ctrlplusb
Update website/docs/docs/api/action.md
ef297d3 
Co-authored-by: Sean Matheson <sean@ctrlplusb.com>
@s900mhz @ctrlplusb
Update website/docs/docs/api/reducer.md
bb5800b 
Co-authored-by: Sean Matheson <sean@ctrlplusb.com>
@s900mhz
Copy link
Contributor Author

s900mhz commented Oct 30, 2022

@ctrlplusb Awesome! I pushed the changes, lmk what you think!

@jmyrland jmyrland merged commit 877f664 into ctrlplusb:master Nov 13, 2022
@jmyrland
Copy link
Collaborator

Thanks for your contribution @s900mhz 👏 This will be included in the release this week!

@no-stack-dub-sack no-stack-dub-sack mentioned this pull request Jan 13, 2023
Closed
@no-stack-dub-sack no-stack-dub-sack mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlplusb ctrlplusb ctrlplusb left review comments

@jmyrland jmyrland jmyrland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s900mhz @jmyrland @ctrlplusb @skspade