test: fix cross-platform persist test issues #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redistribute wait times and more specifically assert that counter is never intermediate change values to account for cross-platform wishy-washiness
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jmyrland did you run this on your machine and confirm it works for you too? |
I can verify that it works on my machine as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix cross-platform issues for persist test
"multiple changes don't cause concurrent persist operations". I noticed that this test passed on my mac, but produced highly inconsistent results on my PC. This commit redistributeswaittimes by making updates to the store in more quick succession and waits longer periods to allow the 80ms to elapse before asserting on the store's state. Also make some asserts a bit more specific, asserting that the counter is never intermediate change values, as on Windows after 40-50ms from the last change the counter updates to 5 inconsistently and unexpectedly early. This should prove that the counter never has an intermediate value but eliminate failures due to this inconsistency. We still validate the final value of the counter as 5.