Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for old firefox which doesn't have isSameNode method #169

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

jongsue
Copy link
Contributor

@jongsue jongsue commented Jun 2, 2019

Hello~
I've been using react-sizeme for almost 1 year now.
It's such a great react components for me.

BTW, There is an issue for old firefox browsers.
I found out this bug because my clients are still using old machines :(

I hope you could accept my pull request so I don't modify react-sizeme sources in node_modules folder everytime I build my application

Thank you in advance

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files           4        4           
  Lines         106      106           
  Branches       25       25           
=======================================
  Hits           96       96           
  Misses          9        9           
  Partials        1        1
Impacted Files Coverage Δ
src/with-size.js 96.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d433fdd...26aa180. Read the comment docs.

@rokoroku
Copy link

@ctrlplusb
Copy link
Owner

Apologies for taking a while to get to this. I'll be reviewing this soon. 👍

@ctrlplusb ctrlplusb merged commit 6df6f68 into ctrlplusb:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants