Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Fixes missing recursive-readdir dependency needed for npm run flow:re… #153

Merged
merged 3 commits into from
Nov 1, 2016

Conversation

alinporumb
Copy link
Contributor

Fixes issue described here: #152

@ctrlplusb
Copy link
Owner

Thanks so much for this. Would you be open to modifying the flow removals script to use the following technique?

https://github.com/ctrlplusb/react-universally/blob/master/tools/development/ensureVendorDLLExists.js#L50

I am happy to add you as a collaborator to this project. I am trying to encourage more help, and it's great to see you taking the initiative here.

@alinporumb
Copy link
Contributor Author

Sure ! I'll gladly make the change & will try to update the PR later today.

Copy link
Owner

@ctrlplusb ctrlplusb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants