Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Adds Dockerfile and docker-compose.yml #158

Closed
wants to merge 1 commit into from
Closed

Conversation

strues
Copy link
Collaborator

@strues strues commented Nov 2, 2016

Resolves #46

Contains Node v7 with Yarn installed on Alpine Linux 3.4

@ctrlplusb
Copy link
Owner

This is great @strues

Thanks!

I am a bit of a docker noob, so I am gonna let this PR sit for a while until I wrap my head around it. I definitely would like us to explore the production use case a bit further too.

What do you see as the major advantages of using the docker container during development vs the "standard" method?

@strues
Copy link
Collaborator Author

strues commented Nov 3, 2016

@ctrlplusb I feel like Docker in this case is slightly unnecessary, but thats just my opinion. I know a lot of people use Docker for everything in development. I usually only run my databases in containers until production.

@ctrlplusb
Copy link
Owner

@strues I would have to agree. I can't see the obvious value in running docker in development.

Lets keep this running though. I am definitely interested in a "production" container configuration.

@ctrlplusb ctrlplusb closed this Dec 6, 2016
@ctrlplusb ctrlplusb deleted the feature/docker branch December 6, 2016 23:24
@oyeanuj
Copy link
Contributor

oyeanuj commented Sep 16, 2017

@strues Wondering if you are maintaining a docker version in your own work for react-universally? If yes, could you share your docker config?

@mschipperheyn
Copy link

I use Dokku myself with React Universally. Curious to understand the difference in use cases, advantage, disadvantage?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants