Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about what windows to replace #245

Merged
merged 1 commit into from
Jun 8, 2016
Merged

Be more explicit about what windows to replace #245

merged 1 commit into from
Jun 8, 2016

Conversation

qstrahl
Copy link

@qstrahl qstrahl commented Apr 26, 2016

@qstrahl
Copy link
Author

qstrahl commented May 3, 2016

@mattn Your thoughts?

@mattn
Copy link
Member

mattn commented May 5, 2016

Do you set g:ctrlp_reuse_window like below?

let g:ctrlp_reuse_window = 'help|quickfix'

@qstrahl
Copy link
Author

qstrahl commented May 5, 2016

Nope, I don't set g:ctrlp_reuse_window at all. Why?

- Just checking for any buftype is insufficient

- See for example justinmk/vim-dirvish#43 -- a directory buffer should
  have buftype=nofile, but ctrlp should still replace it

- Look instead for buftype=help or buftype=quickfix, explicitly
@qstrahl
Copy link
Author

qstrahl commented Jun 6, 2016

Rebased the branch up to date with latest in master. What do I have to do to get this merged in?

@qstrahl qstrahl closed this Jun 6, 2016
@qstrahl
Copy link
Author

qstrahl commented Jun 6, 2016

Oops, didn't mean to close it. :x

@qstrahl qstrahl reopened this Jun 6, 2016
@mattn
Copy link
Member

mattn commented Jun 8, 2016

okay, I'll merge this. however, I wonder what we will have to add another file types into the buftypes.

@mattn mattn merged commit d9d09b6 into ctrlpvim:master Jun 8, 2016
@mattn
Copy link
Member

mattn commented Jun 8, 2016

Thanks.

@p8
Copy link

p8 commented Nov 16, 2017

Replacing
let buftypes = [ 'quickfix', 'help']
with
let buftypes = [ 'quickfix', 'help', 'nofile' ]
fixed it for me.

Now even when the NERDTree buffer is active ctrlp doesn't open the file in the NERDTree buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants