Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem #47

Merged
merged 3 commits into from
Apr 10, 2021
Merged

fix problem #47

merged 3 commits into from
Apr 10, 2021

Conversation

boxjan
Copy link
Contributor

@boxjan boxjan commented Apr 7, 2021

  • rclone use 1.54.1
  • add EnsureFSMetaExist func, if removeBucket or removePrefix failed, will not out of control
  • fix removeObjects error check
  • add removeObjectsOneByOne, when removeObjects failed, will try to use it
  • fix repeat in yaml

* rclone use 1.54.1
* add EnsureFSMetaExist func
* fix removeObjects have err check
* add removeObjectsOneByOne, when removeObjects failed, will try to use it
* fix repeat in yaml
@boxjan
Copy link
Contributor Author

boxjan commented Apr 7, 2021

I use digitalocean s3, it not support file lock...

Copy link
Owner

@ctrox ctrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks like there have been a few weird yaml errors that popped up during my merges in the past few days. I have added a few comments.

pkg/driver/controllerserver.go Outdated Show resolved Hide resolved
pkg/driver/controllerserver.go Outdated Show resolved Hide resolved
pkg/s3/client.go Outdated Show resolved Hide resolved
pkg/s3/client.go Outdated Show resolved Hide resolved
@ctrox ctrox merged commit 0433ead into ctrox:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants