Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level to StreamHandler #22

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add log level to StreamHandler #22

merged 1 commit into from
Apr 16, 2024

Conversation

mbentz-uf
Copy link
Contributor

@mbentz-uf mbentz-uf commented Apr 15, 2024

What does this change do?

Set the log level of the StreamHandler.

Why was this change made?

The logs to the console did not contain DEBUG log entries. Updating the log level of the StreamHandler fixes this.

Verification

Run the sample script in PyCustodian with the latest changes to test.

  1. In PyCustodian checkout PR 109
  2. In pyproject.toml replace tag = "2.3.1" with rev = "9fd646c272336af7d436ddcc9fcad7c284e255d6"
  3. Run poetry upgrade
  4. Run the sample script with and without the verbose flag
    • py-custodian run sample_script.py
    • py-custodian run sample_script.py --verbose

Verify that the logs contain DEBUG entries when the script is run using the --verbose flag, and are not included when run without the --verbose flag.

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I have added docstrings with details on keyword arguments to new functions following the convention detailed in this gist
  • I have added type hinting to new function parameters.
  • I have added tests to new functions, following the rules of F.I.R.S.T..
  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

@vdeshpande7 vdeshpande7 self-requested a review April 15, 2024 21:03
@mbentz-uf mbentz-uf merged commit 86aff25 into develop Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants