-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 #17
Merged
Merged
Version 2.0.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace recursive logic in _getFormattedSettings with getSubSettings
@saipavan10-git, could you document the breaking change and write some SQL code to help people get form 1.x to 2.0.0?
Consult with me if you have trouble. |
@saipavan10-git , the old screenshot is now out of date. Could you update it with a v2.0.0 screenshot and double-check that the text still makes sense? |
Updated the README to have only the image of new configuration. Also removed the old config image from the image assets.
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Replaces #11 using checkboxes as detailed in #11 (comment)
Refactors module to use framework version 15.
Needs a commit to update the README to reflect breaking changes and the new checkbox fields.
Note that there is currently no automated migration provided from v1.x.x to v2.0.0 as
redcap_module_system_change_version
is deprecated andredcap_module_system_enable
does not give me access to the framework, so I can't even usegetProjectsWithModuleEnabled
for manual migration let alone any of the nicer functions for detecting config to infer version. Users will unfortunately have to reselect their scoping; CSS and form scoping should be retained though.