Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edituser #140

Closed
wants to merge 24 commits into from
Closed

Feature/edituser #140

wants to merge 24 commits into from

Conversation

KevinHanson
Copy link
Contributor

This feature adds the ability to edit a user after they have been added in dropper.

ndavuluri and others added 22 commits May 19, 2016 13:26
Created check to see if we are in an edit state when using the form then call appropriate api route.
pulled duplicated code into utils.py
Automatic rendering of updated users.
Complete implementation of user role assignment
- Client side uses checkboxes for role selection now.
- Tested api's for save and edit
- Possible bug found regarding default email_confirmed_at date in user entity unit tests:
UserEntity passes an arg for email verification time as “server_default='0000-00-00 00:00:00'” which
causes a “OverflowError: date value out of range” in the tzinfo.py library when running the unit tests.
This error is either not present or does nothing in production. Further changing the date to a recent
one sidesteps the problem
… downgrades

Other changes are for unit testing
@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 63.766% when pulling 55f9ca8 on feature/edituser into 497170f on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 63.766% when pulling ea8b2cc on feature/edituser into 497170f on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 63.766% when pulling ff5ece0 on feature/edituser into 497170f on develop.

@KevinHanson
Copy link
Contributor Author

Canceling to have Patrick submit the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants