fix: don't break when user overrides ModelAdmin.has_change_permission #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefterisnik
reviewed
Jun 29, 2017
| return change_permission | ||
| return change_permission | ||
|
|
||
| def has_change_permission_only_change(self, request, obj=None): |
There was a problem hiding this comment.
Could you add some tests for this function? Also, could you make this function private as it is used internally only? I think has_change_permission_only it would be better name. The _change I think it is redundant.
|
Hi @PetrDlouhy, Thanks you for the PR. It is very useful. |
|
@lefterisnik Thanks for merging. Are all requested changes already made? |
|
Hi @PetrDlouhy, yes, they have been added 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation is not compatible with projects and applications where is
has_change_permissionfunction is overriden. Such asdjango-advanced-filters. This fixes that.