Do not return prepopulated fields for view only users #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lefterisnik is the project still alive ? I'm going to use it and would like to use it from original repo rather then the fork. Would you mind taking a quick review and merging this branch ? It's pretty simple |
|
@lefterisnik what do you think about the PR ? |
|
I will merge this asap
…On Wed, 1 Aug 2018, 10:02 Anton Shutik, ***@***.***> wrote:
@lefterisnik <https://github.com/lefterisnik> what do you think about the
PR ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGIJZSfvRMaKCBnA2uJ2J7cLBIiG9vY0ks5uMW67gaJpZM4VhwuB>
.
|
|
@lefterisnik thanks, there are some tests failing, looks like smth wrong with configuration. Is there anything I can help with ? |
|
@lefterisnik Thank you so much. When do you plan to release that to pypi ? |
|
In a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #52
If customer has read permission only, do not return
prepopulated_fields, return empty dict instead