Add collection view for menu view #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YKo20010
reviewed
Mar 24, 2019
|
|
||
| // MARK: Constraint setup | ||
| private func setUpConstraints() { | ||
| let leadingOffset: CGFloat = 24 |
There was a problem hiding this comment.
might want to put constants at the top along with view vars
|
Merged with master and updated design |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
| } | ||
|
|
||
| private func loadMenu() { | ||
| // TODO: get menu from endpoint |
There was a problem hiding this comment.
TODOs should be resolved (get menu from endpoint).todo MenuViewController.swift:63 |
kevinchan159
previously approved these changes
Mar 26, 2019
| var bottomSeparator: UIView! | ||
|
|
||
| // var additionalPricingLabel: UILabel! | ||
| // var selectButton: UIButton! |
There was a problem hiding this comment.
remove if unnecessary
| // selectButton.setTitle("Select", for: .normal) | ||
| // selectButton.backgroundColor = UIColor(red: 1.0, green: 156.0 / 255.0, blue: 29.0 / 255.0, alpha: 1.0) | ||
| // selectButton.tintColor = .white | ||
| // contentView.addSubview(selectButton) |
There was a problem hiding this comment.
remove if unnecessary
| let imageViewWidthHeight: CGFloat = 64 | ||
| let imageViewStackViewHorizontalSpacing: CGFloat = 24 | ||
| let bottomSeparatorHeight: CGFloat = 1.0 | ||
| // let stackViewSelectButtonHorizontalSpacing: CGFloat = 17 |
There was a problem hiding this comment.
remove if unnecessary
| make.leading.equalTo(imageView.snp.trailing).offset(imageViewStackViewHorizontalSpacing) | ||
| make.centerY.equalToSuperview() | ||
| make.trailing.equalToSuperview().inset(trailingInset) | ||
| // make.trailing.equalTo(selectButton.snp.leading).offset(-stackViewSelectButtonHorizontalSpacing) |
| // selectButton.snp.makeConstraints { make in | ||
| // make.trailing.equalToSuperview().inset(trailingInset) | ||
| // make.width.equalTo(selectButtonWidth) | ||
| // make.centerY.equalToSuperview() |
doctor3w
force-pushed
the
jaewon/menu-view
branch
from
e53df02
to
aed0c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8