Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to switch off the first component focusing #1472

Closed
glebfox opened this issue Oct 29, 2018 · 1 comment
Closed

Add ability to switch off the first component focusing #1472

glebfox opened this issue Oct 29, 2018 · 1 comment
Assignees
@Flaurite @myatlevEvg
Labels
state: fixed Fixed by the developer type: enhancement New feature or request ver: 7.1.0 Fixed in version
Milestone
Release 7.1

Comments

@glebfox
Copy link
Member

glebfox commented Oct 29, 2018 •
edited by Flaurite

Currently, if no focusComponent is set, then the first possible component is focused, excluding buttons.

It would be useful to have a possibility to disable this feature in case we want to focus a component by a custom logic.

  1. Implement focusComponent options: AUTO, OFF
  2. Remove the code that excludes buttons from the default focusing logic

Changes

In v7 screen xml added new attribute:

  • focusMode with one option NO_FOCUS
  • focuseMode is not defined. It means that window will focus components as it is defined in default logic:
    if focusComponent is defined it will be focused, if focusComponent is not defined window will focus fisrt founded component.
  • NO_FOCUS. it means that window will not focus components. Even if focusComponent is defined.

Note, now buttons can be focused if window wll try to find first component to focus. (if focusComponent is not specified and focusMode is AUTO)

How to test

  1. Check above-mentioned options are worked correctly.
@glebfox glebfox added this to the Release 7.1 milestone Oct 29, 2018
@glebfox glebfox self-assigned this Oct 29, 2018
@glebfox glebfox added the type: enhancement New feature or request label Oct 29, 2018
@glebfox glebfox mentioned this issue Oct 29, 2018
Closed
Flaurite added a commit that referenced this issue Apr 9, 2019
@Flaurite
Add ability to switch off the first component focusing #1472
75a8a9b
@haulmont-git haulmont-git added the ver: 7.1.0 Fixed in version label Apr 9, 2019
@Flaurite Flaurite assigned natfirst and unassigned glebfox Apr 9, 2019
@natfirst natfirst assigned myatlevEvg and unassigned natfirst Apr 12, 2019
@myatlevEvg myatlevEvg added the state: fixed Fixed by the developer label Apr 12, 2019
@Flaurite Flaurite reopened this May 16, 2019
@Flaurite
Copy link
Contributor

Improve API for focus mode

@Flaurite Flaurite removed the state: fixed Fixed by the developer label May 16, 2019
Flaurite added a commit that referenced this issue May 17, 2019
@Flaurite
Add ability to switch off the first component focusing #1472
5af142b 
Get rid of getter and setter of focusMode
Flaurite added a commit that referenced this issue May 20, 2019
@Flaurite
Add ability to switch off the first component focusing (return AUTO m…
3eede22 
…ode) #1472
@myatlevEvg myatlevEvg added the state: fixed Fixed by the developer label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flaurite Flaurite

@myatlevEvg myatlevEvg

Labels
state: fixed Fixed by the developer type: enhancement New feature or request ver: 7.1.0 Fixed in version
Projects
None yet
Milestone
Release 7.1
Development

No branches or pull requests
6 participants
@jreznot @glebfox @natfirst @haulmont-git @Flaurite @myatlevEvg