Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluentValueLoader changed methods #1893

Closed
pctF opened this issue Feb 20, 2019 · 1 comment
Closed

FluentValueLoader changed methods #1893

pctF opened this issue Feb 20, 2019 · 1 comment
Assignees
@knstvk
Labels
state: fixed Fixed by the developer type: regression ver: 7.0.2 Fixed in version ver: 7.1.0 Fixed in version
Milestone
Release 7.0

Comments

@pctF
Copy link

pctF commented Feb 20, 2019 •
edited

Just finished migration from 6.10.* -> 7.* . Seems like fluent loader changed api
6.10: public FluentValueLoader<T> softDeletion(boolean softDeletion)
7.0: public FluentValueLoader softDeletion(boolean softDeletion)
etc

Is it intentional or we can expect changes in future versions?

  • Platform version: 7.0.1

expected behavior (old one):

Long salary = dataManager.loadValue("select u.salary  from ...", Long.class)
    .parameter("id", id)
    .one();

actual:

Long salary = (Long) dataManager.loadValue("select u.salary  from ...", Long.class)
    .parameter("id", id)
    .one();
@knstvk knstvk self-assigned this Feb 21, 2019
@knstvk knstvk added this to the Release 7.0 milestone Feb 21, 2019
knstvk added a commit that referenced this issue Feb 21, 2019
@knstvk
Incorrect casting of value in DataManager.loadValue() #1005
a75226a 
FluentValueLoader changed methods #1893
@haulmont-git haulmont-git added the ver: 7.1.0 Fixed in version label Feb 21, 2019
knstvk added a commit that referenced this issue Feb 21, 2019
@knstvk
Incorrect casting of value in DataManager.loadValue() #1005
4adeccd 
FluentValueLoader changed methods #1893
@haulmont-git haulmont-git added the ver: 7.0.2 Fixed in version label Feb 21, 2019
@knstvk knstvk added type: regression state: fixed Fixed by the developer labels Feb 21, 2019
@knstvk knstvk closed this as completed Feb 21, 2019
@knstvk
Copy link
Member

knstvk commented Feb 21, 2019

Thank you for reporting.
It was a bug due to improper merging of an old fix.

andreysubbotin pushed a commit that referenced this issue Mar 13, 2019
@knstvk
Incorrect casting of value in DataManager.loadValue() #1005
9e310fe 
FluentValueLoader changed methods #1893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knstvk knstvk

Labels
state: fixed Fixed by the developer type: regression ver: 7.0.2 Fixed in version ver: 7.1.0 Fixed in version
Projects
None yet
Milestone
Release 7.0
Development

No branches or pull requests
3 participants
@knstvk @haulmont-git @pctF