Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupStyleProvider is never invoked for generating styles #2581

Closed
dtsaryov opened this issue Dec 6, 2019 · 0 comments
Closed

GroupStyleProvider is never invoked for generating styles #2581

dtsaryov opened this issue Dec 6, 2019 · 0 comments
Assignees
Labels
state: fixed Fixed by the developer type: regression ver: 7.1.4 Fixed in version ver: 7.2.0 Fixed in version
Milestone

Comments

@dtsaryov
Copy link
Contributor

dtsaryov commented Dec 6, 2019

See a topic on support forum: link

Description of the bug or enhancement

Upd.

GroupTable has GroupStyleProvider for generating group row styles. But it is never invoked.

Steps to reproduce

  1. For groupTable set GroupStyleProvider:
@Inject
private GroupTable<Test> testsTable;

@Subscribe
public void onInit(InitEvent event) {
    testsTable.setStyleProvider(new GroupTable.GroupStyleProvider<Test>() {
        @Nullable
        @Override
        public String getStyleName(GroupInfo info) {
          return "group-test";
        }
        @Override
        public String getStyleName(Test entity, @Nullable String property) {
            return null;
        }
    });
}
  1. Make some column grouped

ER
In the Browser devTools we should see that the group row has "group-test" selector.
AR
Selector is not added.

Test project on 7.2-SNAPSHOT: dev-gtable.zip

@dtsaryov dtsaryov added the type: enhancement New feature or request label Dec 6, 2019
@knstvk knstvk modified the milestone: Release 7.2 Dec 9, 2019
@dtsaryov dtsaryov assigned dtsaryov and Flaurite and unassigned t1-cuba and dtsaryov Dec 23, 2019
@Flaurite Flaurite changed the title Support style provider for GroupTable groups GroupStyleProvider is never invoked for generating styles Dec 24, 2019
@Flaurite Flaurite added type: bug Something isn't working and removed type: enhancement New feature or request labels Dec 24, 2019
@Flaurite Flaurite added this to the Release 7.1 milestone Dec 24, 2019
@haulmont-git haulmont-git added the ver: 7.2.0 Fixed in version label Dec 24, 2019
@haulmont-git haulmont-git added the ver: 7.1.4 Fixed in version label Dec 24, 2019
@Flaurite Flaurite added type: regression and removed type: bug Something isn't working labels Dec 24, 2019
@Flaurite Flaurite assigned dtsaryov and natfirst and unassigned dtsaryov Dec 24, 2019
@natfirst natfirst assigned MikhailSilk and unassigned natfirst Dec 25, 2019
@MikhailSilk MikhailSilk added the state: fixed Fixed by the developer label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: fixed Fixed by the developer type: regression ver: 7.1.4 Fixed in version ver: 7.2.0 Fixed in version
Projects
None yet
Development

No branches or pull requests

7 participants