Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim ".0" postfix when converting Float to Utf8 #32

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

MazterQyou
Copy link
Member

This PR alters the way Float types are converted to Utf8, trimming the ".0" postfix if a float has no fractional part. This is in accordance with how PostgreSQL converts floats to text, and does not affect Decimal (numeric) which retain their fractional part even if it is 0.

@github-actions github-actions bot added the arrow label Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (9f2e286) to head (ff899fb).

❗ Current head ff899fb differs from pull request most recent head 8a5e7e0. Consider uploading reports for the commit 8a5e7e0 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           cubesql-v11.1.0      #32   +/-   ##
================================================
  Coverage            82.80%   82.80%           
================================================
  Files                  190      190           
  Lines                55376    55389   +13     
================================================
+ Hits                 45852    45867   +15     
+ Misses                9524     9522    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit f32dc0f into cubesql-v11.1.0 Mar 4, 2024
25 of 29 checks passed
@MazterQyou MazterQyou deleted the cubesql-float-trim-0 branch March 4, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants