Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC-1327] Trigger onDismiss on Esc press #224

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

MrFlashAccount
Copy link
Contributor

Describe changes

This PR fixes a bug when onDismiss didn't trigger on ESC press.

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: CC-1327

Other information

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: 64e5819

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-90d1ee5.

@github-actions
Copy link
Contributor

🏗 Docs are successfully deployed!

👀 Preview: https://63354d871a19b463f71faa5d--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 137.41 KB (+0.03% 🔺) Yes 🎉
Tree shaking (just a Button) 25.85 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Member

@tenphi tenphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would probably add more cases to cover resolve callback and rejecting by the close button.

@MrFlashAccount MrFlashAccount merged commit 6f58989 into main Oct 3, 2022
@MrFlashAccount MrFlashAccount deleted the feature/CC-1327 branch October 3, 2022 09:19
@github-actions github-actions bot mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants