Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Make storybook as dev dependencies #437

Merged
merged 3 commits into from
Mar 27, 2024
Merged

fix(deps): Make storybook as dev dependencies #437

merged 3 commits into from
Mar 27, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Mar 26, 2024

Hello!

I've found that in the Cube repository we install a separate @babel/core.

=> Found "jscodeshift#@babel/core@7.23.9"
info This module exists because "_project_#@cubejs-client#playground#@cube-dev#ui-kit#storybook#@storybook#cli#jscodeshift" depends on it.
=> Found "@storybook/codemod#@babel/core@7.23.9"
info This module exists because "_project_#@cubejs-client#playground#@cube-dev#ui-kit#storybook#@storybook#cli#@storybook#codemod" depends on it.
info Disk size without dependencies: "5.84MB"
info Disk size with unique dependencies: "31.03MB"
info Disk size with transitive dependencies: "54.57MB"

Thanks

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 26c9352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 9:39pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://660340a45d352f00a8c002a9--cubejs-docs-staging.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-29a9504.

@github-actions GitHub Actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 201.62 KB (0% 🟰) Yes 🎉
Tree shaking (just a Button) 27.28 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@ovr ovr requested a review from tenphi March 27, 2024 08:51
@ovr ovr merged commit 5411b86 into main Mar 27, 2024
13 checks passed
@ovr ovr deleted the fix/deps-story-book branch March 27, 2024 13:45
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
@ovr ovr mentioned this pull request Mar 27, 2024
Merged
ovr added a commit to cube-js/cube that referenced this pull request Mar 27, 2024
@ovr
chore(playground): Upgrade @cube-dev/ui-kit (#8028)
0e0bd96 
It's needed to remove unexpected dependencies from storybook like @babel/core

refs cube-js/cube-ui-kit#437
JichaoS pushed a commit to luabase/cube that referenced this pull request May 7, 2024
@ovr @JichaoS
chore(playground): Upgrade @cube-dev/ui-kit (cube-js#8028)
6cb21ac 
It's needed to remove unexpected dependencies from storybook like @babel/core

refs cube-js/cube-ui-kit#437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenphi tenphi tenphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ovr @tenphi