feat: Introduce CUBEJS_DEV_MODE & improve ENV variables experience #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
force-pushed
the
shared-env
branch
3 times, most recently
from
b28bdaa
to
9a5292e
Compare
ovr
force-pushed
the
shared-env
branch
2 times, most recently
from
c6fc21b
to
4e25889
Compare
hassankhan
approved these changes
Nov 11, 2020
4 tasks
keydunov
reviewed
Nov 12, 2020
hassankhan
reviewed
Nov 16, 2020
…for Cube.js backend
feat(@cubejs-backend/server): Introduce CUBEJS_DEV_MODE
…tion, it's needed to detect docker image)
vasilev-alex
approved these changes
Nov 16, 2020
vasilev-alex
pushed a commit
that referenced
this pull request
Dec 14, 2020
…1356) * feat(@cubejs-backend/shared): Introduce new package for sharing code for Cube.js backend * feat(@cubejs-backend/server): Use getEnv from shared instead of process.env * fix(docker): cubejs/cube:dev - register backend-shared library * feat(@cubejs-backend/server): Introduce CUBEJS_DEV_MODE feat(@cubejs-backend/server): Introduce CUBEJS_DEV_MODE * misc(docs): Drop CUBEJS_DOCKER_IMAGE_TAG (it's not a configuration option, it's needed to detect docker image) * chore!(cubejs-cli): Drop dev-server command (replaced by CUBEJS_DEV_MODE) * feat(@cubejs-backend/server): Run server command by default from cubejs-server * feat(cubejs-cli): docker template - use cubejs-server without command * feat(docker): Install rxvt-unicode * feat(docker): Setup NODE_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks