chore!(cubejs-cli): Drop dev-server command (replaced by CUBEJS_DEV_M…

…ODE)
cube-js · Nov 11, 2020 · 9a5292e · 9a5292e
1 parent 538f89f
commit 9a5292e
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 37 deletions.
diff --git a/docs/Cube.js-Backend/Config.md b/docs/Cube.js-Backend/Config.md
@@ -454,7 +454,7 @@ Boolean to enable or disable a check duplicate property names in all objects of
 
 Since 0.23 Cube.js CLI uses `docker` insead of `express` template as a default for app creation and it's recommended way for production purposes.
 To migrate you should move all of your Cube.js dependencies in package.json to `devDependencies` and leave all of your dependencies that you use to configure Cube.js in `dependencies`.
-Also `./node_modules/.bin/cubejs-server dev-server` command should be used to run Cube.js Dev Server.
+
 For example:  
 
 **package.json**:
@@ -485,7 +485,7 @@ Should become
   "version": "0.0.1",
   "private": true,
   "scripts": {
-    "dev": "./node_modules/.bin/cubejs-server dev-server"
+    "dev": "./node_modules/.bin/cubejs-server server"
   },
   "dependencies": {
     "jwk-to-pem": "^2.0.4"

diff --git a/docs/Cube.js-Backend/Deployment.md b/docs/Cube.js-Backend/Deployment.md
@@ -14,7 +14,7 @@ Below you can find guides for popular deployment environments:
 
 ## Production Mode
 
-When running Cube.js Backend in production make sure `NODE_ENV` is set to `production`.
+When running Cube.js Backend in production make sure `NODE_ENV` is set to `production` and `CUBEJS_DEV_MODE` is not set to `true`.
 Such platforms, such as Heroku, do it by default.
 In this mode Cube.js unsecured development server and Playground will be disabled by default because there's a security risk serving those in production environments.
 Production Cube.js servers can be accessed only with [REST API](rest-api) and Cube.js frontend libraries.

diff --git a/docs/Cube.js-ClI/Reference.md b/docs/Cube.js-ClI/Reference.md
@@ -42,27 +42,6 @@ Create app called `demo-app` using `serverless` template and `athena` database:
 $ cubejs create demo-app -d athena -t serverless
 ```
 
-## dev-server
-
-[[warning | Note]]
-| To define configuration you should use `cube.js` configuration file. See [available options](https://cube.dev/docs/@cubejs-backend-server-core#options-reference).
-
-The `dev-server` command starts Cube.js in development mode.
-
-### Usage
-
-Default start:
-
-```bash
-$ cubejs dev-server
-```
-
-With debug information:
-
-```sh
-$ cubejs dev-server --debug
-```
-
 ## server
 
 [[warning | Note]]

diff --git a/packages/cubejs-cli/src/cli.ts b/packages/cubejs-cli/src/cli.ts
@@ -1,6 +1,5 @@
 import program from 'commander';
 
-import { configureDevServerCommand } from './command/dev-server';
 import { configureServerCommand } from './command/server';
 import { configureDeployCommand } from './command/deploy';
 import { configureCreateCommand } from './command/create';
@@ -28,7 +27,6 @@ program
   await configureCreateCommand(program);
   await configureGenerateCommand(program);
   await configureDeployCommand(program);
-  await configureDevServerCommand(program);
   await configureServerCommand(program);
 
   if (!process.argv.slice(2).length) {

diff --git a/packages/cubejs-cli/src/command/dev-server.ts b/packages/cubejs-cli/src/command/dev-server.ts
diff --git a/packages/cubejs-cli/src/templates.ts b/packages/cubejs-cli/src/templates.ts
@@ -241,8 +241,6 @@ services:
       # - .:/cube/conf
       - ./cube.js:/cube/conf/cube.js
       - ./schema:/cube/conf/schema
-    # Remove this line for production, dev-server must be used only during development
-    entrypoint: cubejs dev-server
 
   redis:
     image: redis:6
@@ -253,7 +251,7 @@ services:
 const templates = {
   docker: {
     scripts: {
-      dev: './node_modules/.bin/cubejs-server dev-server',
+      dev: './node_modules/.bin/cubejs-server server',
     },
     files: {
       'cube.js': () => cubeJs,