Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compareDateRange needs to be added to the type definitions for #1621

Closed
cbroome opened this issue Dec 16, 2020 · 1 comment
Closed

compareDateRange needs to be added to the type definitions for #1621

cbroome opened this issue Dec 16, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@cbroome
Copy link
Contributor

cbroome commented Dec 16, 2020

Describe the bug

The article on https://cube.dev/blog/comparing-data-over-different-time-periods/ describes a new compareDateRange property available on TimeDimensions. Based on what I could see this is available in the repository however it doesn't look like the type definitions were added so it is unavailable for Typescript projects.

To Reproduce
Steps to reproduce the behavior:

  1. npm install the latest cubejs-core (0.24.8 as of this writing)
  2. Include cubejs-core
  3. Try to instantiate a query with a compareDateRange property in a Typescript file.

Expected behavior
Typescript projects can use the compareDateRange property

Version:

  • @cubejs-client/core": "^0.24.8"
  • @cubejs-client/react": "^0.24.8"
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 16, 2020
@cbroome
fix(@cubejs-core): Add type definition for compareDateRange, fix cube…
6ae0b8d 
…-js#1621
@cbroome cbroome mentioned this issue Dec 16, 2020
Merged
4 tasks
@vasilev-alex vasilev-alex added the bug Something isn't working label Dec 17, 2020
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 17, 2020
@cbroome
fix(@cubejs-core): Add type definition for compareDateRange, fix cube…
835d4a7 
…-js#1621
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 17, 2020
@cbroome
fix(@cubejs-core): make the type definitions a little less strict fix c…
9078f53 
…ube-js#1621
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 17, 2020
@cbroome
fix(@cubejs-core): make the type definitions even a little less stric…
d3700d1 
…ter fix cube-js#1621
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 17, 2020
@cbroome
fix(@cubejs-core): use types instead of interfaces for TimeDimensions c…
caa676d 
…ube-js#1621
cbroome added a commit to cbroome/cube.js that referenced this issue Dec 17, 2020
@cbroome
fix(@cubejs-core): stricter enforcement for DateRange type in TimeDim…
5547eca 
…ensions cube-js#1621
@SoozaV
Copy link

SoozaV commented Jul 26, 2023

This is not completed yet:

image

version 0.33.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbroome @vasilev-alex @SoozaV