Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove job from pre-aggregations queue, Debug API #3148

Merged
merged 5 commits into from Jul 24, 2021

Conversation

RusovDmitriy
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Remove job from pre-aggregations queue, Debug API

@RusovDmitriy RusovDmitriy requested a review from a team as a code owner July 23, 2021 05:27
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #3148 (5f93105) into master (69d5baf) will decrease coverage by 0.19%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   59.41%   59.21%   -0.20%     
==========================================
  Files         124      124              
  Lines        9518     9555      +37     
  Branches     2119     2124       +5     
==========================================
+ Hits         5655     5658       +3     
- Misses       3577     3607      +30     
- Partials      286      290       +4     
Impacted Files Coverage Δ
...-orchestrator/src/orchestrator/LocalQueueDriver.js 90.96% <0.00%> (-2.65%) ⬇️
...y-orchestrator/src/orchestrator/PreAggregations.ts 85.00% <0.00%> (-0.45%) ⬇️
...orchestrator/src/orchestrator/QueryOrchestrator.ts 61.68% <0.00%> (-1.18%) ⬇️
...-query-orchestrator/src/orchestrator/QueryQueue.js 70.72% <0.00%> (-1.63%) ⬇️
...-orchestrator/src/orchestrator/RedisQueueDriver.js 2.68% <0.00%> (-0.12%) ⬇️
...ges/cubejs-server-core/src/core/OrchestratorApi.ts 58.10% <0.00%> (-0.80%) ⬇️
packages/cubejs-api-gateway/src/gateway.ts 68.79% <11.11%> (-0.97%) ⬇️
packages/cubejs-api-gateway/src/query.js 73.83% <33.33%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d5baf...5f93105. Read the comment docs.

@@ -189,6 +189,11 @@ export class OrchestratorApi {
return result;
}

public async cancelPreAggregationQueriesFromQueue(queryKeys: string[], dataSource: string) {
const result = await this.orchestrator.cancelPreAggregationQueriesFromQueue(queryKeys, dataSource);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const result = await this.orchestrator.cancelPreAggregationQueriesFromQueue(queryKeys, dataSource);
return this.orchestrator.cancelPreAggregationQueriesFromQueue(queryKeys, dataSource);

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RusovDmitriy RusovDmitriy merged commit 2e244db into master Jul 24, 2021
@RusovDmitriy RusovDmitriy deleted the feat-remove-from-queue branch July 24, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants