Skip to content

Commit

Permalink
fix(@cubejs-client/react): QueryBuilder incorrectly deduplicates filt…
Browse files Browse the repository at this point in the history
…ers based only on member instead of member+operator (#2948) (#3147)
  • Loading branch information
rdwoodring committed Jul 23, 2021
1 parent 453a92c commit 69d5baf
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions packages/cubejs-client-react/src/QueryBuilder.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,11 @@ export default class QueryBuilder extends React.Component {
dryRunResponse,
} = this.state;

const flatFilters = uniqBy(
prop('member'),
const flatFilters = uniqBy((filter) => `${prop('member', filter)}${prop('operator', filter)}`,
flattenFilters((meta && query.filters) || []).map((filter) => ({
...filter,
member: filter.member || filter.dimension,
}))
);
})));

const filters = flatFilters.map((m, i) => ({
...m,
Expand Down

0 comments on commit 69d5baf

Please sign in to comment.