Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-orchestrator): introduce unload without temp table #5324

Merged
merged 8 commits into from
Sep 23, 2022

Conversation

frolovdev
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 84.19% // Head: 60.15% // Decreases project coverage by -24.04% ⚠️

Coverage data is based on head (217b6ba) compared to base (ae78a8d).
Patch coverage: 77.63% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5324       +/-   ##
===========================================
- Coverage   84.19%   60.15%   -24.05%     
===========================================
  Files         135      140        +5     
  Lines       21367    11684     -9683     
  Branches        0     2945     +2945     
===========================================
- Hits        17991     7028    -10963     
- Misses       3376     4150      +774     
- Partials        0      506      +506     
Flag Coverage Δ
cube-backend 60.15% <77.63%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/cubejs-base-driver/src/driver.interface.ts 50.00% <ø> (ø)
packages/cubejs-base-driver/src/BaseDriver.ts 27.16% <50.00%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 79.46% <78.37%> (ø)
...pile/engine/information_schema/postgres/pg_enum.rs
rust/cubesql/cubeclient/src/apis/mod.rs
rust/cubesql/cubeclient/src/apis/configuration.rs
rust/cubesql/cubesql/src/compile/service.rs
...rmation_schema/postgres/referential_constraints.rs
rust/cubesql/cubesql/src/error.rs
rust/cubesql/cubesql/src/sql/types.rs
... and 268 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frolovdev frolovdev marked this pull request as ready for review September 20, 2022 13:22
@frolovdev frolovdev requested a review from a team as a code owner September 20, 2022 13:22
@frolovdev frolovdev changed the title Fix temp table feat(query-orchestrator): introduce unload without temp table Sep 20, 2022
@frolovdev frolovdev merged commit 3dcbd2e into master Sep 23, 2022
@frolovdev frolovdev deleted the fix-temp-table branch September 23, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants