Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ngx cubejs.watch() not producing errors #3974

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

PieterVanZyl-Dev
Copy link
Contributor

[Fix] ngx cubejs.watch() not producing errors.
[Spelling] apiInstace -> apiInstance

Check List

  • [N/A] Tests has been run in packages where changes made if available
  • [N/A] Linter has been run for changed code
  • [N/A] Tests for the changes have been added if not covered yet
  • [N/A] Docs have been added / updated if required

Issue Reference this PR resolves

#3961

Description of Changes Made (if issue reference is not provided)

Added a try catch to throw errors when the watch() promise fails.

[Fix] ngx cubejs.watch() not producing errors.
@PieterVanZyl-Dev PieterVanZyl-Dev requested a review from a team as a code owner January 22, 2022 15:08
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jan 22, 2022
@PieterVanZyl-Dev
Copy link
Contributor Author

@vasilev-alex

I think this is in your area of expertise.

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #3974 (ad068a3) into master (3afe2b1) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
+ Coverage   57.79%   58.02%   +0.23%     
==========================================
  Files         126      127       +1     
  Lines       10524    10646     +122     
  Branches     2556     2592      +36     
==========================================
+ Hits         6082     6177      +95     
- Misses       3967     3993      +26     
- Partials      475      476       +1     
Flag Coverage Δ
cube-backend 58.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...schema-compiler/src/compiler/DataSchemaCompiler.js 52.24% <0.00%> (-0.94%) ⬇️
packages/cubejs-backend-shared/src/env.ts 33.52% <0.00%> (-0.83%) ⬇️
packages/cubejs-api-gateway/src/graphql.ts 4.16% <0.00%> (-0.62%) ⬇️
...ejs-schema-compiler/src/parser/GenericSqlParser.ts 56.93% <0.00%> (-0.45%) ⬇️
...cubejs-query-orchestrator/src/driver/BaseDriver.js 26.06% <0.00%> (-0.32%) ⬇️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 63.44% <0.00%> (-0.22%) ⬇️
...-query-orchestrator/src/orchestrator/QueryQueue.js 69.20% <0.00%> (-0.09%) ⬇️
packages/cubejs-api-gateway/src/gateway.ts 67.46% <0.00%> (ø)
packages/cubejs-schema-compiler/src/index.ts 100.00% <0.00%> (ø)
packages/cubejs-api-gateway/src/sql-server.ts 6.89% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c857562...ad068a3. Read the comment docs.

@paveltiunov paveltiunov merged commit 1ee6740 into cube-js:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants