Skip to content

Commit

Permalink
fix(snowflake-driver): Unable to detect a Project Id in the current e…
Browse files Browse the repository at this point in the history
…nvironment for GCS export bucket
  • Loading branch information
paveltiunov committed Apr 12, 2024
1 parent 50d03a3 commit 03ca8fa
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
* Returns an array of signed URLs of the unloaded csv files.
*/
private async getCsvFiles(tableName: string): Promise<string[]> {
const { bucketType, bucketName } =
const { bucketType, bucketName, credentials } =

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / unit (20.x)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, snowflake)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, bigquery)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / unit (18.x)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, athena)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / Build native Linux 18 x86_64-unknown-linux-gnu Python fallback

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cubestore (18.x)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.

Check failure on line 580 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-smoke (18.x)

Property 'credentials' does not exist on type 'SnowflakeDriverExportBucket'.
<SnowflakeDriverExportBucket> this.config.exportBucket;
switch (bucketType) {
case 's3':
Expand All @@ -601,9 +601,8 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
case 'gcs':
return this.extractFilesFromGCS(
new Storage({
credentials: (
<SnowflakeDriverExportGCS> this.config.exportBucket
).credentials,
credentials,
projectId: credentials.project_id

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / unit (20.x)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, snowflake)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, bigquery)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / unit (18.x)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cloud (18.x, athena)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / Build native Linux 18 x86_64-unknown-linux-gnu Python fallback

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cubestore (18.x)

Property 'project_id' does not exist on type 'object'.

Check failure on line 605 in packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts

View workflow job for this annotation

GitHub Actions / integration-smoke (18.x)

Property 'project_id' does not exist on type 'object'.
}),
bucketName,
tableName,
Expand Down

0 comments on commit 03ca8fa

Please sign in to comment.