feat: Support probing LIMIT 0 queries

cube-js · May 13, 2024 · 117f332 · 117f332
1 parent ef09ee1
commit 117f332
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/cubejs-api-gateway/src/query.js b/packages/cubejs-api-gateway/src/query.js
@@ -108,7 +108,7 @@ const querySchema = Joi.object().keys({
   ),
   segments: Joi.array().items(Joi.alternatives(id, memberExpression)),
   timezone: Joi.string(),
-  limit: Joi.number().integer().min(1),
+  limit: Joi.number().integer().min(0),
   offset: Joi.number().integer().min(0),
   total: Joi.boolean(),
   renewQuery: Joi.boolean(),

diff --git a/packages/cubejs-testing/test/smoke-cubesql.test.ts b/packages/cubejs-testing/test/smoke-cubesql.test.ts
@@ -269,5 +269,11 @@ limit
       const resDate = await connection.query(queryCtor('createdAtMaxProxy'));
       expect(resDate.rows).toMatchSnapshot('date case');
     });
+
+    test('zero limited dimension aggregated queries', async () => {
+      const query = 'SELECT MAX(createdAt) FROM Orders LIMIT 0';
+      const res = await connection.query(query);
+      expect(res.rows).toEqual([]);
+    });
   });
 });