fix(cubestore): Escape regex symbols in all versions of like operator (…

…#7176)
cube-js · Sep 28, 2023 · e58af39 · e58af39
1 parent 5e68c7c
commit e58af39
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/rust/cubestore/Cargo.lock b/rust/cubestore/Cargo.lock
diff --git a/rust/cubestore/cubestore-sql-tests/src/tests.rs b/rust/cubestore/cubestore-sql-tests/src/tests.rs
@@ -1621,6 +1621,17 @@ async fn ilike(service: Box<dyn SqlClient>) {
         .unwrap();
     assert_eq!(to_rows(&r), rows(&["some_underscore"]));
 
+    let r = service
+        .exec_query("SELECT t FROM s.strings WHERE t ILIKE CONCAT('%', '(', '%') ORDER BY t")
+        .await
+        .unwrap();
+    assert_eq!(to_rows(&r), rows(&["test ( special 2"]));
+
+    let r = service
+        .exec_query("SELECT t FROM s.strings WHERE t ILIKE CONCAT('%', '?*|+', '%') ORDER BY t")
+        .await
+        .unwrap();
+    assert_eq!(to_rows(&r), rows(&["111 test {)?*|+aaa"]));
     // Compare constant string with a bunch of patterns.
     // Inputs are: ('aba', '%ABA'), ('ABa', '%aba%'), ('CABA', 'aba%'), ('ZABA', '%a%b%a%'),
     //             ('ZZZ', 'zzz'), ('TTT', 'TTT').
@@ -1630,6 +1641,12 @@ async fn ilike(service: Box<dyn SqlClient>) {
         .unwrap();
     assert_eq!(to_rows(&r), rows(&["%ABA", "%a%b%a%", "%aba%", "aba%"]));
 
+    let r = service
+        .exec_query("SELECT pat FROM s.strings WHERE 'ggggtest (fjfj)' ILIKE pat ORDER BY pat")
+        .await
+        .unwrap();
+    assert_eq!(to_rows(&r), rows(&["%test (%"]));
+
     // Compare array against array.
     let r = service
         .exec_query("SELECT t, pat FROM s.strings WHERE t ILIKE pat ORDER BY t")